fix: set failure reason regardless of crash policy #3835

MasterPtato · 2026-01-12T19:09:00Z

No description provided.

MasterPtato · 2026-01-12T19:09:10Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

claude · 2026-01-12T19:11:36Z

PR Review: fix: set failure reason regardless of crash policy

Summary: This PR fixes an issue where the failure reason was not being set consistently across all crash policies.

Key Changes:

Refactored failure reason handling - Moved SetFailureReason activity calls earlier
Removed state.failure_reason reset - Failure reasons now persist across restarts
Fixed workflow name handling - Added proper error handling for missing workflows

Code Quality:
Strengths - Correct precedence, better separation of concerns, defensive programming
Concerns - Line 1073 ctx.removed call unclear, state persistence needs review, needs comments

Recommendations:
HIGH - Clarify intent of ctx.removed at line 1073
MEDIUM - Consider clearing failure_reason on successful exit
TESTING - Add integration tests for crash policy scenarios

Assessment: Good fix addressing real bug. Improves code clarity. Some edge cases need clarification.

Recommendation: Approve with minor suggestions.

pkg-pr-new · 2026-01-12T19:11:57Z

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3835

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3835

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3835

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3835

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3835

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3835

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3835

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@3835

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3835

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3835

commit: 97ace26

graphite-app · 2026-01-14T23:40:11Z

Merge activity

Jan 14, 11:40 PM UTC: MasterPtato added this pull request to the Graphite merge queue.
Jan 14, 11:41 PM UTC: CI is running for this pull request on a draft pull request (#3908) due to your merge queue CI optimization settings.
Jan 14, 11:42 PM UTC: Merged by the Graphite merge queue via draft PR: #3908.

MasterPtato requested a review from NathanFlurry January 12, 2026 19:09

MasterPtato force-pushed the 01-12-fix_set_failure_reason_regardless_of_crash_policy branch from f7e33e7 to b613527 Compare January 12, 2026 19:11

MasterPtato force-pushed the 01-09-feat_add_metrics_to_pb_guard branch from 9297e74 to 442651f Compare January 12, 2026 19:11

This was referenced Jan 12, 2026

fix(pb): have restart policy actors sleep after pending for too long #3837

Closed

chore: clean up errors #3846

Closed

fix(epoxy): add metrics #3847

Closed

MasterPtato force-pushed the 01-12-fix_set_failure_reason_regardless_of_crash_policy branch from b613527 to b4daf93 Compare January 13, 2026 00:27

MasterPtato force-pushed the 01-09-feat_add_metrics_to_pb_guard branch 2 times, most recently from 7915d6f to 258ae43 Compare January 13, 2026 00:44

MasterPtato force-pushed the 01-12-fix_set_failure_reason_regardless_of_crash_policy branch 2 times, most recently from 0b9ca2f to 1a08758 Compare January 13, 2026 01:01

MasterPtato force-pushed the 01-09-feat_add_metrics_to_pb_guard branch 2 times, most recently from 42cfc6d to 506742d Compare January 13, 2026 01:29

MasterPtato force-pushed the 01-12-fix_set_failure_reason_regardless_of_crash_policy branch from 1a08758 to 5b1c724 Compare January 13, 2026 01:29

This was referenced Jan 13, 2026

fix: add ready_chunks to worker bumps, bumps per tick metric #3855

Closed

fix(guard): clean up guard #3862

Closed

fix(otel): enrich http traces #3878

Closed

chore(gas): add overview and history docs #3879

Closed

MasterPtato force-pushed the 01-09-feat_add_metrics_to_pb_guard branch from 506742d to ca4cbfc Compare January 14, 2026 02:05

MasterPtato force-pushed the 01-12-fix_set_failure_reason_regardless_of_crash_policy branch from 5b1c724 to 8152462 Compare January 14, 2026 02:05

MasterPtato force-pushed the 01-09-feat_add_metrics_to_pb_guard branch from ca4cbfc to 8102256 Compare January 14, 2026 03:06

MasterPtato force-pushed the 01-12-fix_set_failure_reason_regardless_of_crash_policy branch from 8152462 to 82ed36d Compare January 14, 2026 03:06

NathanFlurry approved these changes Jan 14, 2026

View reviewed changes

MasterPtato force-pushed the 01-12-fix_set_failure_reason_regardless_of_crash_policy branch from 82ed36d to f5a4f68 Compare January 14, 2026 19:47

MasterPtato force-pushed the 01-09-feat_add_metrics_to_pb_guard branch 2 times, most recently from 4b907cb to dc985c0 Compare January 14, 2026 20:01

MasterPtato force-pushed the 01-12-fix_set_failure_reason_regardless_of_crash_policy branch from f5a4f68 to 9e4ae6f Compare January 14, 2026 20:01

This was referenced Jan 14, 2026

fix(engine-runner): handle shutdown close codes correctly #3896

Closed

fix(pegboard): cache none runner pool errors too #3899

Closed

MasterPtato force-pushed the 01-09-feat_add_metrics_to_pb_guard branch from dc985c0 to f3f7d72 Compare January 14, 2026 22:52

MasterPtato force-pushed the 01-12-fix_set_failure_reason_regardless_of_crash_policy branch 2 times, most recently from 595d7b8 to 250667d Compare January 14, 2026 23:02

MasterPtato force-pushed the 01-09-feat_add_metrics_to_pb_guard branch from f3f7d72 to ae1c40c Compare January 14, 2026 23:02

MasterPtato force-pushed the 01-12-fix_set_failure_reason_regardless_of_crash_policy branch from 250667d to 980dd0a Compare January 14, 2026 23:07

MasterPtato force-pushed the 01-09-feat_add_metrics_to_pb_guard branch from ae1c40c to 3da23f7 Compare January 14, 2026 23:07

fix: set failure reason regardless of crash policy

97ace26

MasterPtato force-pushed the 01-12-fix_set_failure_reason_regardless_of_crash_policy branch from 980dd0a to 97ace26 Compare January 14, 2026 23:39

MasterPtato force-pushed the 01-09-feat_add_metrics_to_pb_guard branch from 3da23f7 to aea6392 Compare January 14, 2026 23:39

graphite-app bot pushed a commit that referenced this pull request Jan 14, 2026

fix: set failure reason regardless of crash policy (#3835)

2f7110c

graphite-app bot closed this Jan 14, 2026

graphite-app bot deleted the 01-12-fix_set_failure_reason_regardless_of_crash_policy branch January 14, 2026 23:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: set failure reason regardless of crash policy #3835

fix: set failure reason regardless of crash policy #3835

Uh oh!

MasterPtato commented Jan 12, 2026

Uh oh!

MasterPtato commented Jan 12, 2026 •

edited

Loading

Uh oh!

claude bot commented Jan 12, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jan 12, 2026 •

edited

Loading

Uh oh!

graphite-app bot commented Jan 14, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: set failure reason regardless of crash policy #3835

fix: set failure reason regardless of crash policy #3835

Uh oh!

Conversation

MasterPtato commented Jan 12, 2026

Uh oh!

MasterPtato commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

claude bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review: fix: set failure reason regardless of crash policy

Uh oh!

pkg-pr-new bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MasterPtato commented Jan 12, 2026 •

edited

Loading

claude bot commented Jan 12, 2026 •

edited

Loading

pkg-pr-new bot commented Jan 12, 2026 •

edited

Loading

graphite-app bot commented Jan 14, 2026 •

edited

Loading